[Backend] Abstract Cloud File Storage Wrapper (S3)#324
Open
armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
Open
[Backend] Abstract Cloud File Storage Wrapper (S3)#324armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
armorbreak001 wants to merge 1 commit intoGalactiGuild:mainfrom
Conversation
Fixes GalactiGuild#295 - Create S3StorageProvider using @aws-sdk/client-s3 (AWS SDK v3) - Streaming upload support via Readable streams (prevents OOM on large files) - Auto-detects content type from file extension - Generates presigned URLs for private/temporary access - Graceful fallback when S3 is not configured - Upload handler: 50MB max, image/PDF MIME types allowed - Returns public HTTP URLs to cached entities - Configured via .env: AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_REGION, AWS_S3_BUCKET - StorageController at POST /storage/upload endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295
What was done
backend/src/storage/s3-storage.provider.ts):@aws-sdk/client-s3(AWS SDK v3) — modern, modular, tree-shakeable{ url, key, bucket }.env,isAvailable()returns false — no crashesAWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY,AWS_REGION,AWS_S3_BUCKETPOST /storage/upload:@aws-sdk/client-s3and@aws-sdk/s3-request-presignerdependenciesHow to verify
.env:cd backend && npm installnpm run start:devcurl -X POST http://localhost:3000/storage/upload -F "file=@/path/to/image.png"https://bucket.s3.region.amazonaws.com/uploads/uuid-filename.png